Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endyear incorrect on series #119

Closed
paxter opened this issue Mar 18, 2018 · 2 comments
Closed

endyear incorrect on series #119

paxter opened this issue Mar 18, 2018 · 2 comments

Comments

@paxter
Copy link
Contributor

paxter commented Mar 18, 2018

For example Sneaky Pete.

$title = new \Imdb\Title(5011816); echo $title->year(); echo $title->endyear();

Output:
20152015

Both return 2015, which is incorrect. endyear() should not be 2015 because the series has not ended yet. Same goes for yearspan():
Array ( [start] => 2015 [end] => 2015 )

@jreklund
Copy link
Collaborator

There are actually some tv-shows that spans over only one year like Cupid. So that code got written for those cases. I have now modified it in case a tv-show haven't finished yet.

@paxter
Copy link
Contributor Author

paxter commented Mar 18, 2018

Wow, thanks a lot for your fast fix! It's working great now. And thank you for your awesome imdb api! :)

@paxter paxter closed this as completed Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants