Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$maxResults is unused in TitleSearch::search() #111

Closed
sp72 opened this issue Dec 9, 2017 · 0 comments
Closed

$maxResults is unused in TitleSearch::search() #111

sp72 opened this issue Dec 9, 2017 · 0 comments

Comments

@sp72
Copy link

sp72 commented Dec 9, 2017

Hello !

First, thank you for your lib.

$maxResults var is not used (nor documented) so the limit is not applied.

public function search($searchTerms, $wantedTypes = null, $maxResults = null) {

v5.2.4

To save some time on runtime, the limit should be applied when you fetch the data.
Inception returns too much results and it's a bit long.

Thanks for the fix. 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sp72