Skip to content

Commit

Permalink
acceptance: respect logDir in local clusters
Browse files Browse the repository at this point in the history
Previously, local clusters would not respect the `-l` flag and always log
into their data directories (which are not saved in CI).
  • Loading branch information
tbg committed Oct 19, 2017
1 parent 3ad578a commit b44f113
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/acceptance/localcluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,10 @@ func (c *Cluster) makeNode(ctx context.Context, nodeIdx int, cfg NodeConfig) (*N
fmt.Sprintf("--cache=256MiB"),
}

if n.Cfg.LogDir != "" {
args = append(args, fmt.Sprintf("--log-dir=%s", n.Cfg.LogDir))
}

n.Cfg.ExtraArgs = append(args, cfg.ExtraArgs...)

if err := os.MkdirAll(n.logDir(), 0755); err != nil {
Expand Down

0 comments on commit b44f113

Please sign in to comment.