Skip to content

Commit

Permalink
acceptance: add TestRapidRestarts
Browse files Browse the repository at this point in the history
See cockroachdb#19559, cockroachdb#19579, cockroachdb#19571 for issues touched by this test (all of which
it reproduced before the preceding commits fixed them).

The changes here (outside of the test) ensure that a single-node instance starts
as quickly as possible, without waiting for ports to be ready or for replication
to have occurred. This was done to remove any additional delay in
`TestRapidRestarts` that could otherwise obscur bugs (for example, consider that
going through `./cockroach quit` was not able to tickle any of the bugs). #
Please enter the commit message for your changes. Lines starting # with '#' will
be ignored, and an empty message aborts the commit.

I was also tempted to "bump" the version upgrade tests to use 1.1 instead of 1.0
since that would have removed a bunch of cruft (since 1.0 doesn't write its
listener files), but I decided against that. As a result, some of the new
accessors look a little unclean, but they should straighten themselves out once
we only rely on listener files.
  • Loading branch information
tbg committed Oct 30, 2017
1 parent 9eb2ba8 commit 7a0d498
Show file tree
Hide file tree
Showing 7 changed files with 334 additions and 116 deletions.
2 changes: 0 additions & 2 deletions pkg/acceptance/cluster/testconfig.proto
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,4 @@ message TestConfig {
// tests such as TestPut that will run indefinitely.
optional int64 duration = 3 [(gogoproto.nullable) = false, (gogoproto.casttype) = "time.Duration"];
optional InitMode init_mode = 4 [(gogoproto.nullable) = false];

// TODO(bram): #4559 once defined, add in a collection of chaos agents here.
}
Loading

0 comments on commit 7a0d498

Please sign in to comment.