Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat provider: Add support for theme configuration per realm #21

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

phillipj
Copy link
Collaborator

This adds support for configuring themes per realm. All four themes can be configured specifically:

  • Account
  • Admin
  • Email
  • Login

This adds support for configuring themes per realm. All four themes
can be configured specifically:
* Account
* Admin
* Email
* Login
@phillipj
Copy link
Collaborator Author

CI fails:

# github.com/hashicorp/terraform/config
../../hashicorp/terraform/config/testing.go:9: t.Helper undefined (type *testing.T has no field or method Helper)
The command "eval go get -t -v ./... " failed. Retrying, 2 of 3.

Looks unrelated to these changes?

@tazjin tazjin self-requested a review September 1, 2017 08:49
@tazjin
Copy link
Owner

tazjin commented Sep 1, 2017

Looks unrelated to these changes?

It probably is ... the CI setup does not use the Repeatr-based builds right now, which means that dependencies are essentially unpinned.

@phillipj
Copy link
Collaborator Author

Anything I can provide to help you review this? Example output or similar?

@tazjin
Copy link
Owner

tazjin commented Sep 25, 2017

The changes look fine to me. There's no easy fix for the CI build, so I'll be merging this in.

@tazjin tazjin merged commit b78c547 into tazjin:master Sep 25, 2017
@phillipj
Copy link
Collaborator Author

@tazjin are you planning to cut a new release with this added feature?

@tazjin
Copy link
Owner

tazjin commented Sep 29, 2017

@phillipj I can cut a new RC for this, but I'm still not declaring it a stable release. I'll presumably go back to this project next week and clean up a bit to get to some form of stable!

@phillipj
Copy link
Collaborator Author

Ahhh, both sounds great! 👍

@tazjin
Copy link
Owner

tazjin commented Sep 29, 2017

@phillipj
Copy link
Collaborator Author

Woopwoop thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants