Skip to content
This repository has been archived by the owner on Dec 21, 2019. It is now read-only.

Pass rendered resource sets to kubectl individually #57

Merged
merged 3 commits into from
Jun 11, 2017

Conversation

tazjin
Copy link
Owner

@tazjin tazjin commented Jun 11, 2017

Please see the individual commits for more information. This resolves #51 and #56, but does not yet implement the missing resource separator warning inside of a single resource set.

@tazjin
Copy link
Owner Author

tazjin commented Jun 11, 2017

A side effect of this is that output now looks a bit nicer, for example:

Loading resources for cluster-config
Loading resources for kube-system/letsencrypt-controller
Loading resources for kube-system/kontemplate-runner
Passing file cluster-config/storage-classes.yaml to kubectl
storageclass "fast" configured (dry run)
storageclass "slow" configured (dry run)
Passing file kube-system/letsencrypt-controller/controller.yaml to kubectl
deployment "letsencrypt-controller" configured (dry run)
Passing file kube-system/kontemplate-runner/runner.yaml to kubectl
configmap "kontemplate-runner-config" configured (dry run)
deployment "kontemplate-runner" configured (dry run)

This makes it a lot easier to see which files potentially contain syntax errors or cause kubectl to fail in some way.

tazjin added 3 commits June 11, 2017 21:46
As a first step in resolving #51 this refactors the `templater`
package to return rendered resource sets as a distinct type.

This also fixes #56
Instead of passing the rendered output of all resource sets to kubectl
simultaneously, build upon the previous commit and pass resource sets
individually to new instances of kubectl.

This resolves #51
@tazjin tazjin force-pushed the refactor/split-resource-set-applications branch from 9a7eb4c to 0e10b47 Compare June 11, 2017 19:46
@tazjin tazjin changed the title Pass rendered resource sets to kontemplate individually Pass rendered resource sets to kubectl individually Jun 11, 2017
@tazjin tazjin merged commit 3cba344 into master Jun 11, 2017
@tazjin tazjin deleted the refactor/split-resource-set-applications branch June 11, 2017 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate documents issue.
1 participant