-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cta): use commander
instead of minimst
#2551
Conversation
alright, checks have passed, I guess this PR is ready to go |
7477422
to
1399ad2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this, but would really like to recommend that you take the time to fill out the template of the PR and give non-informed readers (aka those not reading every channel on discord) justification for replacing functionality. This is also useful for posterity.
yeah that's totally my bad, I think I forgot |
I marked this as a draft as I think I still need to do some changes to this PR before merge. |
alright this is ready, but probably need to be merged after the audit as it introduces a new dependency. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
commander
is more robust thanminimst
, two main features I appreciate is: