Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svelte recipe to create-tauri-app (#2276) #2279

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Add svelte recipe to create-tauri-app (#2276) #2279

merged 5 commits into from
Jul 22, 2021

Conversation

krscott
Copy link
Contributor

@krscott krscott commented Jul 22, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Implementing #2276

@krscott krscott requested a review from a team as a code owner July 22, 2021 15:27
amrbashir
amrbashir requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks for your contribution, just small nitpicks and this PR is ready to go.

tooling/create-tauri-app/src/recipes/svelte.ts Outdated Show resolved Hide resolved
tooling/create-tauri-app/src/recipes/svelte.ts Show resolved Hide resolved
tooling/create-tauri-app/src/recipes/svelte.ts Outdated Show resolved Hide resolved
tooling/create-tauri-app/src/recipes/svelte.ts Outdated Show resolved Hide resolved
krscott added 2 commits July 22, 2021 13:13
@krscott
Add PR feedback
75eff25 
* Fix Svelte template URL
* Add beforeBuildCommand and beforeDevCommand
* Improve postInit log message
@krscott
Add '--' after 'npm tauri'
68e6a21
@amrbashir
Copy link
Member

don't forget to run yarn format in tooling/create-tauri-app

amrbashir
amrbashir approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@amrbashir amrbashir linked an issue Jul 22, 2021 that may be closed by this pull request
Add Svelte to create-tauri-app #2276
Closed
@amrbashir
Copy link
Member

sorry, one more thing, can you add a change file in .changes folder,

---
"create-tauri-app": patch
---

Add Svelte recipe using the official template.

@lemarier lemarier merged commit 151c315 into tauri-apps:dev Jul 22, 2021
@krscott
Copy link
Contributor Author

krscott commented Jul 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Svelte to create-tauri-app
3 participants
@krscott @amrbashir @lemarier