-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular create tauri app [#1934] #2203
Angular create tauri app [#1934] #2203
Conversation
Looks good, can you add a change file (a markdown file on the .changes folder)? Contents like this:
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, thanks for your efforts, can you add some tests in tooling/create-tauri-app/test/index.spec.ts
and add the recipe to the list of recipes in .github/workflows/test-cta.yml
?
Hmm do I have something to do to get the tests passed? 🤔 |
The error is quite strange. I just reran the tests, let's see what happens. |
Hmm, this is super strange. Have to pull in the heavyweights. @jbolda & @rajivshah3 - have you guys ever seen git fail like this in a workflow? |
@Epsilon02 can you merge with Thanks! |
Hi @Epsilon02, Thanks for your contribution we do appreciate it a lot. Looks like the action never really run successfully as seen here; @jbolda I think this is for you ;) ☝️ LGTM as it should be handled in another PR |
Hi @lemarier |
We should release in the upcoming days! Stay tuned ;) |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
closes #1934