Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tauri.js): remove create command #1265

Merged
merged 1 commit into from
Feb 21, 2021
Merged

refactor(tauri.js): remove create command #1265

merged 1 commit into from
Feb 21, 2021

Conversation

nklayman
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Removes the create command as that will be replaced by #1106. Also fixes a bug where window title wouldn't set properly due to the window config being an array. Additionally, it adjusts shorthand args to make more sense by making common args lowercase instead of uppercase. This is a breaking change but probably won't cause any issues.

@nklayman
refactor(tauri.js): remove create command
ef128cb 
also fixes window title not setting properly because window config is an array
@nklayman nklayman requested a review from a team February 21, 2021 01:23
@lucasfernog lucasfernog merged commit b29c068 into dev Feb 21, 2021
@lucasfernog lucasfernog deleted the remove-create-command branch February 21, 2021 14:26
jbolda added a commit that referenced this pull request Mar 4, 2021
@jbolda
Partial revert "refactor(tauri.js): remove create command (#1265)"
d0e2591 
This reverts commit b29c068.
jbolda added a commit that referenced this pull request Mar 7, 2021
@jbolda
feat: shift tauri create [not wired up] (#1330)
4ec20a4 
* Partial revert "refactor(tauri.js): remove create command (#1265)"

This reverts commit b29c068.

* shift templates/recipes over

* shift remaining files that weren't removed

* add change file

* rename to create-tauri-app

* adjust covector config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklayman @lucasfernog