Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use specta's derive feature #10362

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

Brendonovich
Copy link
Member

@Brendonovich Brendonovich commented Jul 23, 2024

Specta recently moved the specta::Type macro to the derive feature, which broke the docs.rs build for beta 24. This PR fixes that, moving to specta rc 16 as the minimum and using the derive feature.

@Brendonovich Brendonovich requested a review from a team as a code owner July 23, 2024 07:50
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Package Changes Through 7ca4c75

There are 5 changes which include @tauri-apps/api with prerelease, tauri-bundler with prerelease, tauri with prerelease, tauri-runtime-wry with prerelease, tauri-runtime with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.0-beta.15 2.0.0-beta.16
tauri-bundler 2.0.1-beta.18 2.0.1-beta.19
tauri-runtime 2.0.0-beta.20 2.0.0-beta.21
tauri-runtime-wry 2.0.0-beta.20 2.0.0-beta.21
tauri 2.0.0-beta.24 2.0.0-beta.25
@tauri-apps/cli 2.0.0-beta.22 2.0.0-beta.23
tauri-cli 2.0.0-beta.22 2.0.0-beta.23

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Brendonovich Brendonovich marked this pull request as draft July 23, 2024 08:33
@oscartbeaumont
Copy link
Member

Published Specta 2.0.0-rc.16 which should hopefully apply the fix to the CI issues we are seeing here.

I don't have access to the branch so @Brendonovich give it a shot.

@Brendonovich Brendonovich marked this pull request as ready for review July 24, 2024 10:13
FabianLars
FabianLars previously approved these changes Jul 24, 2024
@FabianLars FabianLars merged commit e177694 into tauri-apps:dev Jul 24, 2024
2 of 3 checks passed
@Brendonovich Brendonovich deleted the specta-derive branch July 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants