Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo change in Next.js getting started docs #2311

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

quiint
Copy link

@quiint quiint commented Jun 18, 2024

Description

Typo change - bunx create next-app to bunx create-next-app
image

@quiint quiint requested a review from a team as a code owner June 18, 2024 18:56
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for tauri-v1 ready!

Name Link
🔨 Latest commit 5c8dba8
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v1/deploys/6671d857ca3a5300084a8874
😎 Deploy Preview https://deploy-preview-2311--tauri-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianLars
Copy link
Member

Why does everyone say something different 😭 #2041 / #2077

@quiint
Copy link
Author

quiint commented Jun 20, 2024

@FabianLars maybe it's on different operating systems? this is what it shows for my linux board:
image

the original issue came from my m1 mac running 1.0.36

@simonhyll
Copy link
Contributor

simonhyll commented Jun 20, 2024

If ran with bunx it should be bunx create-next-app. If ran with bun it should be bun create next-app. Anything else is a user side issue

What bun does is check in npmjs for a package called create-next-app, which is made available in a prettier way by doing bun create next-app. This is the same way all JS package managers handle the create functionality

What bunx does is the same as e.g. npx, which is download the specified package, in other words create-next-app, and runs it.

So if anybody raises more PR's regarding "fixing" this, don't merge anything other than what's actually correct. If they're able to run bunx create next-app it's something weird on their system, it's actively against the official patterns and intended usages.

Copy link
Contributor

@simonhyll simonhyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bunx this updated version is indeed the correct syntax. If anyone says otherwise, they're wrong.

@simonhyll simonhyll merged commit 4eacd6b into tauri-apps:v1 Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants