Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linux): remove zbus and use unity launcher APIs directly #880

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir
Copy link
Member Author

I have wasted so much time today trying to see if this implementation works but I can't confirm that it works at all, I couldn't also get the zbus implementation to work as well.

@lucasfernog lucasfernog marked this pull request as ready for review February 21, 2024 11:42
@lucasfernog lucasfernog requested a review from a team as a code owner February 21, 2024 11:42
@lucasfernog lucasfernog merged commit 2af9131 into dev Feb 21, 2024
9 checks passed
@lucasfernog lucasfernog deleted the refactor/remove-zbus branch February 21, 2024 12:53
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
@zeenix
Copy link

zeenix commented Mar 22, 2024

I have wasted so much time today trying to see if this implementation works but I can't confirm that it works at all,

This also adds more code and hence complexity but if maintainers are happy, why not? :)

I couldn't also get the zbus implementation to work as well.

In the future, if you have problems using zbus, do consider asking for help, either in our issues, discussions or our Matrix channel.

@amrbashir
Copy link
Member Author

@zeenix thank you, it wasn't an issue with zbus itself at all. I simply wasn't able to observe the effects of the implementation on the window manager.

As for the decision to remove zbus, was because it added a bit of size (around 500kb) to the minimalist tauri app. We still use zbus in other places like single-instance and notifications (through notify-rust) plugins but that's optional additions.

@zeenix
Copy link

zeenix commented Mar 24, 2024

@zeenix thank you, it wasn't an issue with zbus itself at all. I simply wasn't able to observe the effects of the implementation on the window manager.

Ah ok.

As for the decision to remove zbus, was because it added a bit of size (around 500kb) to the minimalist tauri app.

Fair enough. I'm working on some changes slowly that should help with the size issue.

We still use zbus in other places like single-instance and notifications (through notify-rust) plugins but that's optional additions.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants