refactor!: relax WindowBuilderExtUnix::with_transient_for window type

.changes/transient-for-relax-constraints.md

@@ -0,0 +1,5 @@
+---
+"tao": "patch"
+---
+
+**Breaking Change**: Changed `WindowBuilderExtUnix::with_transient_for` signature to take `&impl gtk::glib::IsA<gtk::Window>` instead of `gtk::ApplicationWindow` which covers more gtk window types and matches the underlying API call signature.

examples/parentwindow.rs

@@ -35,7 +35,7 @@ fn main() {
   let child_window_builder = child_window_builder.with_parent_window(parent_window.clone());
 
   #[cfg(target_os = "linux")]
-  let child_window_builder = child_window_builder.with_transient_for(parent_window.clone());
+  let child_window_builder = child_window_builder.with_transient_for(parent_window);
 
   let child_window = child_window_builder.build(&event_loop).unwrap();
 

src/platform/unix.rs

@@ -80,7 +80,7 @@ pub trait WindowBuilderExtUnix {
   fn with_skip_taskbar(self, skip: bool) -> WindowBuilder;
   /// Set this window as a transient dialog for `parent`
   /// <https://gtk-rs.org/gtk3-rs/stable/latest/docs/gdk/struct.Window.html#method.set_transient_for>
-  fn with_transient_for(self, parent: gtk::ApplicationWindow) -> WindowBuilder;
+  fn with_transient_for(self, parent: &impl gtk::glib::IsA<gtk::Window>) -> WindowBuilder;
 
   /// Whether to enable or disable the internal draw for transparent window.
   ///
@@ -124,8 +124,9 @@ impl WindowBuilderExtUnix for WindowBuilder {
     self
   }
 
-  fn with_transient_for(mut self, parent: gtk::ApplicationWindow) -> WindowBuilder {
-    self.platform_specific.parent = Parent::ChildOf(parent);
+  fn with_transient_for(mut self, parent: &impl gtk::glib::IsA<gtk::Window>) -> WindowBuilder {
+    use gtk::glib::Cast;
+    self.platform_specific.parent = Parent::ChildOf(parent.clone().upcast());
     self
   }
 

src/platform_impl/linux/mod.rs

@@ -41,7 +41,7 @@ pub struct KeyEventExtra {
 #[derive(Clone)]
 pub enum Parent {
   None,
-  ChildOf(gtk::ApplicationWindow),
+  ChildOf(gtk::Window),
 }
 
 impl Default for Parent {

src/platform_impl/linux/window.rs

@@ -77,10 +77,16 @@ impl Window {
     let app = &event_loop_window_target.app;
     let window_requests_tx = event_loop_window_target.window_requests_tx.clone();
     let draw_tx = event_loop_window_target.draw_tx.clone();
-    let window = gtk::ApplicationWindow::builder()
+
+    let mut window_builder = gtk::ApplicationWindow::builder()
       .application(app)
-      .accept_focus(attributes.focused)
-      .build();
+      .accept_focus(attributes.focused);
+    if let Parent::ChildOf(parent) = pl_attribs.parent {
+      window_builder = window_builder.transient_for(&parent);
+    }
+
+    let window = window_builder.build();
+
     let window_id = WindowId(window.id());
     event_loop_window_target
       .windows
@@ -212,10 +218,6 @@ impl Window {
       window.hide();
     }
 
-    if let Parent::ChildOf(parent) = pl_attribs.parent {
-      window.set_transient_for(Some(&parent));
-    }
-
     // restore accept-focus after the window has been drawn
     // if the window was initially created without focus
     if !attributes.focused {