fix(android) fix app crash on restart due to Android context not released #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that causes the app to crash when it is restarted after any exit that triggers the onDestroy callback.
To reproduce this bug:
npm run tauri android buildRustStdoutStderr: assertion failed: previous.is_none()The bug occurs because the Android context is not released when the app is destroyed, and the ndk-context crate asserts that the context is initialized only once.
This PR adds a call to release_android_context when the app is destroyed. This ensures that the Android context is freed and can be reinitialized on the next launch.
This PR is based on this commit from the ndk-glue repository.