Fix WindowEvent::Destroyed might fire twice on macOS
#831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
approved these changes
Oct 29, 2023
amrbashir
reviewed
Oct 29, 2023
| autoreleasepool(move || { | ||
| ns_window.close(); | ||
| let event = Event::WindowEvent { | ||
| window_id: WindowId(get_window_id(*ns_window.0)), | ||
| event: WindowEvent::Destroyed, |
There was a problem hiding this comment.
why was this event removed? is the destroyed event sent somewhere else?
There was a problem hiding this comment.
This is a workaround we did before.
It should be sent by windowWillClose in window's delegate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information