fix(windows): fix build error on target i686-pc-windows-msvc #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `error[E0793]: reference to packed field is unaligned`.
amrbashir
requested changes
May 9, 2023
amrbashir
approved these changes
May 9, 2023
|
I hope you don't mind but your solution was panicking at runtime so I added a commit to fix that and added the change file as well. |
Merged
amrbashir
added a commit
that referenced
this pull request
May 22, 2023
* fix(windows): fix build error on target i686-pc-windows-msvc Fix `error[E0793]: reference to packed field is unaligned`. * fix implementation --------- Co-authored-by: amrbashir <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
error[E0793]: reference to packed field is unaligned.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information
This PR fixes Tauri 0.13 build error on target i686-pc-windows-msvc.