-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menus): add app name to native Quit and Hide items, closes #536 #570
Conversation
Sorry, forgot |
This feels to me like a much cleaner implementation now, thanks for the pointers @amrbashir. Could you just confirm that you're happy with these changes to the |
I think that the Option should be reintroduced. You can't really expect that CFBundleName is set in all scenarios |
Thanks for all the reviews @amrbashir 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Implemented by getting the name of the current app from
NSRunningApplication
and adding it to the menu items labels.closes #536