fix(menus): macOS Services menu not working, closes #243 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Sep 25, 2022
Wait, there are changefiles now? Nice! |
amrbashir
approved these changes
Sep 25, 2022
|
thank you |
Merged
This was referenced Oct 5, 2022
|
Is this divider redundant? |
caesar
commented
Nov 11, 2022
| @@ -308,10 +308,12 @@ impl Menu { | |||
| )), | |||
| MenuItem::Services => unsafe { | |||
| let item = make_menu_item("Services", None, None, MenuType::MenuBar); | |||
| // we have to assign an empty menu as the app's services menu, and macOS will populate it | |||
| let services_menu = NSMenu::alloc(nil).autorelease(); | |||
There was a problem hiding this comment.
Suggested change
| let services_menu = NSMenu::alloc(nil).autorelease(); | |
| let services_menu = NSMenu::new(nil).autorelease(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
closes #243