-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linux/globalShortcut): disable on wayland #543
Conversation
can you also add a change file in |
A change file should be added now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Running rustfmt as ci complains. This sadly makes the diff harder to read. |
It is fine but looks like you're commits are not signed, and I won't be able to merge unless they are signed. |
Don't start the global shortcut thread on wayland, as its highly x11 specific and otherwise results in a segfault in libX11.
On Fri, 2022-08-26 at 11:12 -0700, Amr Bashir wrote:
It is fine but looks like you're commits are not signed, and I won't be
able to merge unless they are signed.
Ah ok, it's signed now.
|
Don't start the global shortcut thread on wayland, as its highly x11
specific and otherwise results in a segfault in libX11.
Disabling the thread allows for example Cinny to start with the envvar DISPLAY unset and GDK_BACKEND=wayland.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information