Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix tray event window showing up on click, closes #506 #507

Merged
merged 4 commits into from
Aug 2, 2022
Merged

fix(windows): fix tray event window showing up on click, closes #506 #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
782ead2
fix(windows): fix tray event window showing up on click, closes #506
amrbashir Aug 1, 2022
1014f7b
changefile
amrbashir Aug 1, 2022
bc6f456
change file
amrbashir Aug 1, 2022
b358d7e
changefile content
amrbashir Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/tray-ghost-window.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tao": "patch"
---

On Windows, fix a ghost window appearing occasionally when clicking the tray icon.
14 changes: 11 additions & 3 deletions src/platform_impl/windows/system_tray.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,18 @@ impl SystemTrayBuilder {
RegisterClassW(&wnd_class);

let hwnd = CreateWindowExW(
Default::default(),
WS_EX_NOACTIVATE | WS_EX_TRANSPARENT | WS_EX_LAYERED |
// WS_EX_TOOLWINDOW prevents this window from ever showing up in the taskbar, which
// we want to avoid. If you remove this style, this window won't show up in the
// taskbar *initially*, but it can show up at some later point. This can sometimes
// happen on its own after several hours have passed, although this has proven
// difficult to reproduce. Alternatively, it can be manually triggered by killing
// `explorer.exe` and then starting the process back up.
// It is unclear why the bug is triggered by waiting for several hours.
WS_EX_TOOLWINDOW,
PCWSTR(class_name.as_ptr()),
"tao_system_tray_window",
WS_OVERLAPPEDWINDOW,
PCWSTR::default(),
WS_OVERLAPPED,
CW_USEDEFAULT,
0,
CW_USEDEFAULT,
Expand Down