feat(linux): Add necessary features for creating GL windows #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
commented
Jul 24, 2022
Comment on lines
+143
to
+156
| // Set GDK Visual | ||
| if let Some(screen) = window.screen() { | ||
| if let Some(visual) = screen.rgba_visual() { | ||
| window.set_visual(Some(&visual)); | ||
| } | ||
| } | ||
|
|
||
| window.connect_draw(|_, cr| { | ||
| cr.set_source_rgba(0., 0., 0., 0.); | ||
| cr.set_operator(cairo::Operator::Source); | ||
| let _ = cr.paint(); | ||
| cr.set_operator(cairo::Operator::Over); | ||
| Inhibit(false) | ||
| }); | ||
| window.set_app_paintable(true); | ||
| // Set a few attributes to make the window can be painted. | ||
| // See Gtk drawing model for more info: | ||
| // https://docs.gtk.org/gtk3/drawing-model.html | ||
| window.set_app_paintable(true); | ||
| let widget = window.upcast_ref::<gtk::Widget>(); | ||
| unsafe { | ||
| gtk::ffi::gtk_widget_set_double_buffered(widget.to_glib_none().0, 0); |
There was a problem hiding this comment.
Many are optional but I make these become default to all windows.
Tested with wry and it looks fine.
This should also reduce some overhead when dealing with draw signal overall.
There was a problem hiding this comment.
sounds fine, we can revert back if any issues are reported.
wusyong
changed the title
amrbashir
requested changes
Jul 24, 2022
- Rename trait method name to `with_transparent_draw`. - Use enum struct variant on WireUpEvents. - Hide doc on x11 module.
amrbashir
approved these changes
Jul 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Here are some features added for incoming GL window feature:
EventLoopWindowTargetExtUnixfor methods to determine if the backend is x11 or wayland.x11module for glutin internal use. This is basically just x11-dl, but winit secretly exports it.auto_transparentattribute so users can draw the window manually.There might be more but these are the minimum requirements for egui + glutin/glow.