Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support theme on macOS #408

Merged
merged 2 commits into from
Jun 1, 2022
Merged

feat: support theme on macOS #408

merged 2 commits into from
Jun 1, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented May 29, 2022 •
edited
Loading

I added support for macOS theme get/set function.
Theme change events are now also supported.

Also I will implement same method on Linux in another PR.

related issue: #387

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@keiya01 keiya01 requested a review from a team May 29, 2022 08:59
@keiya01 keiya01 requested a review from a team as a code owner May 29, 2022 08:59
@keiya01 keiya01 self-assigned this May 29, 2022
@keiya01 keiya01 marked this pull request as draft May 29, 2022 13:00
@keiya01
Copy link
Member Author

keiya01 commented May 29, 2022

I will try to implement set theme and listen theme change event in this PR.

@keiya01 keiya01 force-pushed the feat/get-theme-on-macos branch from 874b430 to 8f90173 Compare May 30, 2022 00:58
@keiya01 keiya01 changed the title feat: add a method to get theme feat: support theme on macOS May 30, 2022
@keiya01 keiya01 marked this pull request as ready for review May 30, 2022 01:01
@keiya01 keiya01 requested a review from a team May 30, 2022 01:01
@keiya01 keiya01 force-pushed the feat/get-theme-on-macos branch from 8f90173 to bf63c64 Compare May 30, 2022 01:01
@keiya01
Copy link
Member Author

keiya01 commented May 30, 2022

I implemented the above comment :)

@keiya01 keiya01 force-pushed the feat/get-theme-on-macos branch 3 times, most recently from 0dca73c to 100497d Compare May 30, 2022 01:59
@keiya01 keiya01 force-pushed the feat/get-theme-on-macos branch from 100497d to 9f1d3f2 Compare May 30, 2022 01:59
wusyong
wusyong previously approved these changes Jun 1, 2022
View reviewed changes
@wusyong wusyong merged commit 8af4d8f into tauri-apps:dev Jun 1, 2022
@github-actions github-actions bot mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees

@keiya01 keiya01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiya01 @wusyong