Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the windows-rs crate to 0.37.0 #400

Merged
merged 14 commits into from
May 23, 2022
Merged

Conversation

wravery
Copy link
Contributor

@wravery wravery commented May 20, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The windows-implement macro which lets you implement COM interfaces with the windows crate depends on const generic support which was just stabilized in rustc 1.61. This effectively raises the MSRV for tao on Windows to 1.61.

@wravery wravery requested a review from a team May 20, 2022 03:31
@wravery wravery requested a review from a team as a code owner May 20, 2022 03:31
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, we appreciate your help.

.changes/windows-0.37.0.md Outdated Show resolved Hide resolved
@wravery
Copy link
Contributor Author

wravery commented May 20, 2022

The change in 793c1e6 goes with tauri-apps/wry@b63db59 to break a dependency on matching windows types in tao and wry. That should make it possible for tao and wry to update windows and use different versions independently so the PRs and crates.io updates don't need to be staged like this in the future. They can be temporarily out of sync for their windows crate versions and still work together.

@wravery
Copy link
Contributor Author

wravery commented May 20, 2022

I undid the changes in b94e19b (bumping the MSRV for tao on all platforms) and documented it in the change log: ef3f1b7.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late merge. been busy on termite crisis whole weekend 😅

@wusyong wusyong merged commit 93c256f into tauri-apps:dev May 23, 2022
@github-actions github-actions bot mentioned this pull request May 23, 2022
@wravery wravery mentioned this pull request May 23, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants