-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement standalone webview ndk #385
Conversation
12bed9b
to
15ff175
Compare
This PR will rewrite whole android stack. |
The work you've done is remarkable but given our decision to move back to use winit, I don't know how will this fit into that. |
Yeah that's my concern too. I think the reasonable choice would be android and linux port in tao will end up remain, and we maintain these ourselves. For the rest platforms, we will re-export from winit. |
yeah that sounds about right. I just thought we were gonna create a |
Oh right, we can still propose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can decide later whether we keep gtk and android webview glue code under tao
or make winit_gtk
and tao
would re-export it. For now, this PR is fine. Great work as always.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information