Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): Fix incorrect Redo and CloseWindow accelerators #166

Merged
merged 2 commits into from
Aug 3, 2021
Merged

fix(macos): Fix incorrect Redo and CloseWindow accelerators #166

merged 2 commits into from
Aug 3, 2021

Conversation

probablykasper
Copy link
Member

Did not understand if I need to make a change file or not

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@probablykasper probablykasper requested a review from a team August 2, 2021 01:27
Copy link
Member

@lemarier lemarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changefile please

also would be great as you are there if you can check #159

thanks

@probablykasper probablykasper requested a review from a team as a code owner August 2, 2021 16:30
@probablykasper
Copy link
Member Author

Changed CloseWindow to CMD+W and added the changefile (Did not understand when change files are needed, maybe the wording of that should be changed?)

@probablykasper probablykasper changed the title fix(macos): Fix incorrect Redo accelerator fix(macos): Fix incorrect Redo and CloseWindow accelerators Aug 2, 2021
@lemarier lemarier merged commit f4d718a into tauri-apps:dev Aug 3, 2021
@github-actions github-actions bot mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants