-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): fix aero-snap and resizing of borderless window, fixes #103 #104 #110
Conversation
If you have trouble seeing the borderless window, try changing this line tao/src/platform_impl/windows/window.rs Line 1008 in cbd4cdb
to hbrBackground: winuser::COLOR_WINDOW as _,
|
Any plans for implementing this as well? https://docs.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmextendframeintoclientarea |
@Blakeinstein what's the use case for it? does the window not have shadows by default ? |
@Blakeinstein just pushed a commit with shadows, test it and let me know what you think. |
Oh yea sorry I wasn't available yesterday. It works great! So does the resize. Can you test one thing for me? Resizing a frameless window had a delay on sending the resize event to the webview on boscop/webview. This results in white gaps being visible for a few seconds. Can you try this with tauri? |
I don't know about cross-compatibility. But later down the road can we expose the margins as an api? example: https://docs.microsoft.com/en-us/windows/win32/dwm/blur-ovw |
I have plans to:
but all of that is out of this PR scope. |
That sounds awesome! Thanks again! |
# Conflicts: # src/platform/windows.rs # src/platform_impl/windows/window.rs
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: