Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): fix aero-snap and resizing of borderless window, fixes #103 #104 #110

Merged
merged 13 commits into from
Jul 7, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 28, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner June 28, 2021 12:27
@amrbashir amrbashir requested a review from a team June 28, 2021 12:27
@amrbashir amrbashir changed the title fix(windows): fix aero-snap and resizing of borderless window fix(windows): fix aero-snap and resizing of borderless window, fixes #103 #104 Jun 28, 2021
@amrbashir
Copy link
Member Author

amrbashir commented Jun 28, 2021

If you have trouble seeing the borderless window, try changing this line

hbrBackground: ptr::null_mut(),

to hbrBackground: winuser::COLOR_WINDOW as _,

@Blakeinstein
Copy link

@amrbashir
Copy link
Member Author

amrbashir commented Jun 28, 2021

@Blakeinstein what's the use case for it? does the window not have shadows by default ?

@amrbashir
Copy link
Member Author

@Blakeinstein just pushed a commit with shadows, test it and let me know what you think.

@Blakeinstein
Copy link

Blakeinstein commented Jun 29, 2021

@Blakeinstein just pushed a commit with shadows, test it and let me know what you think.

Oh yea sorry I wasn't available yesterday. It works great!

So does the resize.

Can you test one thing for me? Resizing a frameless window had a delay on sending the resize event to the webview on boscop/webview. This results in white gaps being visible for a few seconds. Can you try this with tauri?

@Blakeinstein
Copy link

I don't know about cross-compatibility. But later down the road can we expose the margins as an api?

example: https://docs.microsoft.com/en-us/windows/win32/dwm/blur-ovw

@amrbashir
Copy link
Member Author

amrbashir commented Jun 29, 2021

I have plans to:

  1. Provide API to set the shadows if possible on all platforms
  2. Provide Blur/Acrylic/Vibrancy API

but all of that is out of this PR scope.

@Blakeinstein
Copy link

I have plans to:

1. Provide API to set the shadows if possible on all platforms

2. Provide Blur/Acrylic/Vibrancy API
   but all of that is out of this PR scope.

That sounds awesome! Thanks again!

@amrbashir amrbashir marked this pull request as draft June 30, 2021 11:11
@wusyong wusyong marked this pull request as ready for review July 7, 2021 05:47
@wusyong wusyong merged commit f35dd03 into dev Jul 7, 2021
@wusyong wusyong deleted the fix/aero-snap branch July 7, 2021 06:21
@github-actions github-actions bot mentioned this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants