Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add is_menu_visible #108

Merged
merged 3 commits into from
Jul 6, 2021
Merged

feat: add is_menu_visible #108

merged 3 commits into from
Jul 6, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 27, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner June 27, 2021 14:43
@amrbashir amrbashir requested a review from a team June 27, 2021 14:43
amrbashir and others added 2 commits June 27, 2021 16:44
@amrbashir
fix typo
d9c9801
@lemarier
Merge remote-tracking branch 'origin/dev' into feat/is-menu-visible
93fea21 
# Conflicts:
#	src/platform_impl/android/mod.rs
#	src/platform_impl/macos/window.rs
#	src/window.rs
@lemarier lemarier merged commit 308411c into dev Jul 6, 2021
@lemarier lemarier deleted the feat/is-menu-visible branch July 6, 2021 11:56
@github-actions github-actions bot mentioned this pull request Jul 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemarier lemarier lemarier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lemarier