Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): remove internal From implementation #1048

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jan 21, 2025

Removes impl From<ActivationPolicy> for NSApplicationActivationPolicy.

This is needed to avoid publicly exposing a dependency on cocoa, which will allow using objc2 in the future.

Removes `impl From<ActivationPolicy> for NSApplicationActivationPolicy`.

This is needed to avoid publicly exposing a dependency on cocoa, which
will allow using `objc2` in the future.
@madsmtm madsmtm requested a review from a team as a code owner January 21, 2025 22:26
Copy link
Contributor

Package Changes Through 68f0f99

There are 1 changes which include tao with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.31.1 0.32.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I should also note that we may never refactor this crate to use objc2 as it is currently in maintenance mode only, and I still think we should go back to use winit.

@madsmtm madsmtm mentioned this pull request Jan 21, 2025
@madsmtm
Copy link
Contributor Author

madsmtm commented Jan 21, 2025

Whoops, didn't see your comment before I posted #1049, let's discuss it over there?

@amrbashir
Copy link
Member

amrbashir commented Jan 21, 2025

I suspected you maybe working on it so I wanted to give you a heads up, thanks anyways, we really appreciate it

@amrbashir amrbashir merged commit 6fda498 into tauri-apps:dev Jan 21, 2025
18 checks passed
@madsmtm madsmtm deleted the remove-cocoa-conversion branch January 22, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants