Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable dragging room according to DPI scaling factor when resizing frameless window #376

Closed
idlist opened this issue Apr 26, 2022 · 3 comments · Fixed by #378
Closed

Comments

@idlist
Copy link

idlist commented Apr 26, 2022

Related to tauri#3040

I'm using a '13 Windows laptop with 4k resolution (3840*2400 in detail) and I currently set the DPI scaling to 250%. Current room for resizing is like only half or even 1/3 of a framed window.

I feel like that simply increasing the resizing border in pixel does not solve the problem. I agree that it would be better if the room could be variable according to the DPI scaling factor.

@amrbashir
Copy link
Member

amrbashir commented Apr 29, 2022

Can you test if #379 fixes this for you?
in a tauri project where you have a borderless window:

  1. add this to you src-tauri/Cargo.toml
    [patch.crates-io]
    tao = {git = "https://github.com/tauri-apps/tao", branch = "fix/scaled-resiznig-handlers"}
  2. run cargo update inside src-tauri

@idlist
Copy link
Author

idlist commented May 1, 2022

I tested and It looks good to me.

On the other hand, though, the broader dragging room emphasizes the flickering of the cursor when the cursor is hovering inside the dragging room (which is also mentioned in tauri#3040) In detail, the cursor would quickly flicker between "default" and "two-sided arrow", and making it somewhat hard to identify if I can resize the window with current cursor position (since sometimes the cursor would be "default" when I stop moving it inside the dragging room).

Although the flickering problem should be another issue (or there has been one but I haven't found that), please feel free to close this issue.

@amrbashir
Copy link
Member

amrbashir commented May 1, 2022

@idlist feel free to open another issue for the flickering and if possible, attach a video recording of the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants