fix(http): inconsistencies on urlpattern usage on scope #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we add some test cases for urls containing query parameters and hash? |
amrbashir
previously approved these changes
Mar 11, 2024
Probably a good idea :) |
lucasfernog
force-pushed
the
fix/http-scope
branch
from
9753c17 to
e091d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the HTTP scope URL parsing to match the behaivor of the JavaScript implementation of URLPattern.
A pattern like
http://localhostshould automatically allow any subpath, query params and hash.To define a custom query param match rule, you must escape the
?character e.g.http://localhost/path\\?q=*&x=*