fix(updater): pass /NS and /UPDATE to nsis installer to disable c…

…reating shortcuts on updates (#1162) * fix(updater): pass `/NS` to nsis installer to disable creating shortcuts on updates ref: tauri-apps/tauri#9395 * add `/UPDATE` * move args to function * update updater test config * revert /R --------- Co-authored-by: Lucas Nogueira <[email protected]>
tauri-apps · May 25, 2024 · 69e4c2e · 69e4c2e
1 parent 7581576
commit 69e4c2e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changes/updater-nsis-shortcuts.md b/.changes/updater-nsis-shortcuts.md
@@ -0,0 +1,5 @@
+---
+"updater": "patch"
+---
+
+Fix NSIS updater creating new shortcuts on update.
diff --git a/plugins/updater/src/updater.rs b/plugins/updater/src/updater.rs
@@ -556,6 +556,8 @@ impl Update {
         match updater_type {
             WindowsUpdaterType::Nsis => {
                 installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new));
+                installer_args.push(OsStr::new("/NS"));
+                installer_args.push(OsStr::new("/UPDATE"));
             }
             WindowsUpdaterType::Msi => {
                 installer_args.extend(install_mode.msiexec_args().iter().map(OsStr::new));

diff --git a/plugins/updater/tests/app-updater/tauri.conf.json b/plugins/updater/tests/app-updater/tauri.conf.json
@@ -21,8 +21,8 @@
       "icons/icon.ico"
     ],
     "windows": {
-      "wix": {
-        "skipWebviewInstall": true
+      "webviewInstallMode": {
+        "type": "skip"
       }
     }
   }