Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix false warning about deno and bun missing #830 #831

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

PawsFunctions
Copy link
Contributor

Set skip to true in case Deno or Bun is the package manager. The existence of the package will be checked separately, and a notice for missing dependencies will still be provided when Cargo is used to create a project with Deno or Bun as the package manager.

@PawsFunctions
Copy link
Contributor Author

It will cover cases and fix notices for Rust, Bun, and Node.js.

I don't have Deno or Node.js, so the notices are accurate.

cargo + Deno

cargo run 001                                                                                                                              create-tauri-app/git/dev !
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
     Running `target/debug/cargo-create-tauri-app 001`
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ 001 directory is not empty, do you want to overwrite? · yes
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, deno, bun)
✔ Choose your package manager · deno
✔ Choose your UI template · Vue - (https://vuejs.org/)
✔ Choose your UI flavor · TypeScript

Template created!

Your system is missing dependencies (or they do not exist in $PATH):
╭──────┬──────────────────────────╮
│ Deno │ Visit https://deno.land/ │
╰──────┴──────────────────────────╯
...

cargo + Bun

cargo run 001                                                                                                                              create-tauri-app/git/dev !
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/cargo-create-tauri-app 001`
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ 001 directory is not empty, do you want to overwrite? · yes
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, deno, bun)
✔ Choose your package manager · bun
✔ Choose your UI template · Vanilla
✔ Choose your UI flavor · TypeScript

Template created! To get started run:
  cd 001
....

No effect on existing solutions

cargo + nodejs (npm | Pnpm | Yarn )

❯ cargo run 001                                                                                                                              create-tauri-app/git/dev !
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
     Running `target/debug/cargo-create-tauri-app 001`
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ 001 directory is not empty, do you want to overwrite? · yes
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, deno, bun)
✔ Choose your package manager · npm
✔ Choose your UI template · Vue - (https://vuejs.org/)
✔ Choose your UI flavor · TypeScript

Template created!

Your system is missing dependencies (or they do not exist in $PATH):
╭─────────┬───────────────────────────╮
│ Node.js │ Visit https://nodejs.org/ │
╰─────────┴───────────────────────────╯
...

Cargo + Rust frontend

 cargo run 001                                                                                                                              create-tauri-app/git/dev !
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/cargo-create-tauri-app 001`
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ 001 directory is not empty, do you want to overwrite? · yes
✔ Choose which language to use for your frontend · Rust - (cargo)
✔ Choose your UI template · Yew - (https://yew.rs/)

Template created! To get started run:
  cd 001
....

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a change file in .changes directory?

@PawsFunctions
Copy link
Contributor Author

Sorry, I just added it now. I hope I did it the right way.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir changed the title Fix false warning deno missing dependencies #830 fix: fix false warning about deno and bun missing #830 Oct 27, 2024
@amrbashir amrbashir merged commit 80e0aa0 into tauri-apps:dev Oct 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants