Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap the cd <dir> instruction in quotes #305

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix: wrap the cd <dir> instruction in quotes #305

merged 1 commit into from
Jan 18, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 18, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir merged commit a5c6dd9 into dev Jan 18, 2023
@amrbashir amrbashir deleted the cd-quotes branch January 18, 2023 13:31
btea
btea reviewed Jan 19, 2023
View reviewed changes
.changes/wrap-path-in-quotes.md
"create-tauri-app": "patch"
---

Wrap the `cd <dir>` instruction in quotes if the project name containts spaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps containts should be contains?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @btea