Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reincorporated Preact and PreactTS templates. #145

Merged
merged 23 commits into from
Aug 30, 2022
Merged

Reincorporated Preact and PreactTS templates. #145

merged 23 commits into from
Aug 30, 2022

Conversation

extrordinaire
Copy link
Contributor

@extrordinaire extrordinaire commented Aug 28, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This PR brings back Preact and PreactTs templates to Tauri create-tauri-app CLI.

amrbashir
amrbashir requested changes Aug 28, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a full review later but for now can you add the new templates in .scripts/generate-templates-matrix.js to the Nodejs templates list so the CI would pick it up and run the test for it?

@extrordinaire
Copy link
Contributor Author

@amrbashir I've done that modification inside .scripts/generate-templates-matrix.js and added that step inside .github/CONTRIBUTING.md 😄

amrbashir
amrbashir requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to take this long to review

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact-ts/index.html Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact-ts/src/app.tsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact-ts/src/app.tsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact-ts/src/app.tsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact/src/app.jsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact/src/app.jsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact/src/app.jsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact/src/app.jsx Outdated Show resolved Hide resolved
packages/cli/fragments/fragment-preact/src/index.css Outdated Show resolved Hide resolved
extrordinaire and others added 7 commits August 30, 2022 15:54
@extrordinaire
Formatted with Cargo and Prettier, fixed misspelled stylesheet index …
33db40f 
…-> style, added vite class to vite logo, fixing the style logo.vite expected behaviour
amrbashir
amrbashir previously approved these changes Aug 30, 2022
View reviewed changes
@amrbashir amrbashir merged commit 0f778e2 into tauri-apps:dev Aug 30, 2022
@amrbashir
Copy link
Member

Thank you @extrordinaire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extrordinaire @amrbashir