Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid configuration is generated for Angular frontend when running with --rc #765

Closed
maciekbartczak opened this issue Aug 28, 2024 · 0 comments · Fixed by #768
Closed

Comments

@maciekbartczak
Copy link

The .manifest file in the angular template contains different entries for beforeDevCommand depending on the target:

beforeDevCommand = {% pkg_manager_run_command %} start

...

[mobile]
beforeDevCommand = {% pkg_manager_run_command %} start {% double_dash_with_space %}--host $HOST --public-host $HOST

However in #748 the differentiation between mobile and non mobile target was removed, which in result makes the generated tauri.conf.json always contain the mobile version of the beforeDevCommand.
This behaviour in my understanding is incorrect, since it requires the HOST environment variable to be set, and running the desktop target using pnpm tauri dev does not set the HOST variable which results in errors during app startup (tauri-apps/tauri#10737).
When the beforeDevCommand in tauri.conf.json is manually set to the regular (non-mobile) version everything works flawlessly.

@maciekbartczak maciekbartczak changed the title Invalid configuration is generated for Angular frontend desktop target when running with --rc Invalid configuration is generated for Angular frontend when running with --rc Aug 28, 2024
@maciekbartczak maciekbartczak changed the title Invalid configuration is generated for Angular frontend when running with --rc Invalid configuration is generated for Angular frontend when running with --rc Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant