TodoMVC using Mojito (v0.5.6 - with updates) #507

gvaish · 2013-03-28T07:54:45Z

Originally for #435 - couldn't find a way to update the same pull request - may be because I scratched the original fork rather than rebasing again.

Commit log

The files in the folder comprise of only the code and not the final running application.

After all hits-and-tries realized that I cannot make it up and running on Github because the application needs to make calls to POST /tunnel and Github pages won't allow that.

passy · 2013-03-28T08:12:27Z

Thanks for the update. For the next time, please force-push to your existing branch and don't open another PR, as @sindresorhus said. Having a new PR for every change gets really confusing quickly.

gvaish · 2013-03-28T08:31:54Z

@passy I know... I also have multiple PRs - it's painful as well!

gvaish · 2013-03-28T08:33:06Z

@caridy - Can you update your task at https://trello.com/card/review-todomvc-by-gaurav/504e5e3b7cd1578456fc430f/406 for this pull request?

passy · 2013-04-04T19:25:08Z

@gvaish Could you check our Contribution Guidelines and make sure to match the code style mentioned there? :)

gvaish · 2013-04-05T03:35:28Z

@passy Yikes. Seems like some work for me this weekend as well! Well, I think I'll pick this up early next week.

addyosmani · 2013-04-10T22:18:48Z

Thanks @gvaish. We appreciate the extra time you're putting in to match our code style. Makes comparison a little more easy :)

gvaish · 2013-04-12T09:25:09Z

Anytime, @addyosmani! :-)
Actually, browsing through I realized that I'd been missing a few test cases as well.

@gvaish

@gvaish Todo using Mojito The files in the folder comprise of only the code and not the final running application. After all hits-and-tries realized that I cannot make it up and running on Github because the application needs to make calls to "POST /tunnel" and Github pages won't allow that. * readme.md: Readme * **/*: Code files @gvaish Updating latest code from the base project at https://github.com/gvaish/todomvc-mojito/tree/master/todomvc-mojito-common

gvaish · 2013-04-13T19:24:19Z

Done.

Squashed commits - did it after eons
Unit Tests - did a lot of them
Coding style - was mostly as mine, so not much of a trouble. jshint only complained of bad option anon, sloppy for jslint, but left in the original code as it's auto generated. It also complained of confusing use of !! at line 37, col 37 - again left it as it is valid.

gvaish · 2013-04-16T07:38:20Z

@passy / @addyosmani - Can you look at it now?

@caridy - Can you look at from Mojito's perspective... may be there's something that you may want to suggest / change / improve.

Changes squashed at https://github.com/gvaish/todomvc/commit/ac94dbb0586c13f1a59302e5c421d2039ee318e7

passy · 2013-04-16T07:43:23Z

@gvaish I'm very happy to see tests here. :)

Could you run jshint with our config on your code? I'm still seeing a few styleguide deviations like function() instead of function ().

addyosmani · 2013-04-23T10:02:44Z

Ping @caridy for any suggestions or a 👍 :)

I really appreciate seeing tests here too, @gvaish - well done. I think this should be good for us to land once we're happy there are no longer styleguide issues.

caridy · 2013-04-23T14:45:07Z

labs/architecture-examples/mojito/application.json

+		"appPort": 6789,
+		"staticHandling": {
+			"appName": "todomvc",
+			"useRollups": false


The staticHandling or useRollups?

userRollups

caridy · 2013-04-23T14:57:33Z

Done with my notes! I found nothing big, but few things that could be improved.

+1

passy · 2013-04-23T14:58:08Z

Thanks for reviewing, @caridy!

gvaish · 2013-04-23T15:08:26Z

Thanks a ton @caridy!
Appreciate the review.

I'd be in London Hackathon this weekend... will try to have a push before month-end (can't guarantee though).

sindresorhus · 2013-05-09T18:27:57Z

ping

gvaish · 2013-05-10T07:36:28Z

No response from the server.

Service will come back to life next week (not weekend).

* application.json: Added assets, cleaned up log * index.js: Deleted, required only for Manhattan * definition.json: Empty, removed * server.js: Updated

gvaish · 2013-05-13T06:03:30Z

Pls use commit at 2c2b912 for review. f1470cf is empty, a166302 is redundant.

The delta comprises of the changes suggested by @caridy, with the major one being refactoring operate action into individual actions like getById, getAll, delete etc.

gvaish · 2013-05-13T06:03:53Z

@sindresorhus Pong! :)

sindresorhus · 2013-05-13T19:46:06Z

@gvaish I can only comment on the code style as I'm not familiar with this framework. Make sure you follow our code style: https://github.com/tastejs/todomvc/blob/gh-pages/codestyle.md

@stephenplusplus @passy anything to add?

stephenplusplus · 2013-05-13T22:45:19Z

I'll be diving into this tonight. From first glance at the readme, getting up and running and the dependency of the other repo seem offputting, though I'm not sure there is a way to avoid this.

stephenplusplus · 2013-05-14T01:43:32Z

I don't want to be a downer as any contribution to TodoMVC is great! However, this seems like more of a "labs" project than an official TodoMVC example. For starters, several files are prefixed with "Copyright (c) 2012 Yahoo! Inc. All rights reserved." However, if this is to be merged, here are just a few suggestions.

As @sindresorhus mentioned, the code style stuff (small things): files currently mix tabs and spaces, rogue indentations, anonymous function() vs anonymous function (). The code style guide will help.

mojits/TodoMojit/assets/ looks like it is intended to hold the todomvc-common files. Please note these have changed, and Bower usage is preferred. Is it possible to use Bower for this dependency and/or any others that the app uses? If not, this folder should be updated to hold the contents from todomvc-common, and include them as well (notably, base.js is missing).

Some functional things:

The readme should definitely be expanded upon. Here are some questions and comments about the readme.

Do I have to do the git clone and all of that, or does the TodoMVC repo contain everything I need?

Why do todomvc-mojito-common and todomvc-mojito-server contain the same files?

cd todo-mojito-common; npm install -d

After I clone your repo, there is a "todomvc-mojito-....", but no "todo-mojito-..." Also, what is -d? (Not familiar with that!)

Is there a reason not to include todomvc-mojito-common and todomvc-mojito-server in the TodoMVC repo? To me, it seems like the dependency on your repo is undesirable/unnecessary(?).

In general, I am unfamiliar with Mojito, so I'm a perfect candidate to get use out of this demonstration. In summary, I'm confused as heck!

Thanks for your patience in working on this demo and tolerating my questions. I look forward to learning more!

gvaish · 2013-05-14T09:42:50Z

@stephenplusplus Quick response: Have a look at https://github.com/gvaish/todomvc-mojito/ for common vs server thing - they are two different implementations using Mojito.

Detailed response: Framing it.

passy · 2013-05-14T11:23:54Z

@stephenplusplus Excellent as always.

I'll also look over it after the next update. :)

gvaish · 2013-05-23T11:16:20Z

Tied up personally. Will take some time...

passy · 2013-05-23T11:30:34Z

@gvaish Thanks for letting us know. :)

addyosmani · 2013-07-13T13:56:04Z

Pinging for a status check :)

gvaish · 2013-07-16T18:54:51Z

Hate to say, but will have to wait for a couple of weeks more :(
I relocated and now settling down.

passy · 2013-07-16T19:19:49Z

@gvaish Thanks for the update!

sindresorhus · 2013-08-17T12:35:45Z

ping

sindresorhus · 2013-08-27T13:36:39Z

closing for lack of activity. We'll reopen when it's ready to be merged. (no need to open a new pr).

This was referenced Mar 28, 2013

HTML5App looking for "POST /tunnel" YahooArchive/mojito#1050

Open

TodoMVC using Mojito #435

Closed

Update html5app artifacts gvaish/todomvc-mojito#7

Open

caridy reviewed Apr 23, 2013
View reviewed changes

gvaish added 3 commits May 13, 2013 11:18

@gvaish Merge remote-tracking branch 't/gh-pages' into gh-pages

a166302

@gvaish Updating Mojito code based on inputs from @caridy

2c2b912

@gvaish Updating Mojito code based on inputs from @caridy

f1470cf

sindresorhus closed this Aug 27, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TodoMVC using Mojito (v0.5.6 - with updates) #507

TodoMVC using Mojito (v0.5.6 - with updates) #507

gvaish commented Mar 28, 2013

passy commented Mar 28, 2013

gvaish commented Mar 28, 2013

gvaish commented Mar 28, 2013

passy commented Apr 4, 2013

gvaish commented Apr 5, 2013

addyosmani commented Apr 10, 2013

gvaish commented Apr 12, 2013

gvaish commented Apr 13, 2013

gvaish commented Apr 16, 2013

passy commented Apr 16, 2013

addyosmani commented Apr 23, 2013

caridy Apr 23, 2013

gvaish Apr 23, 2013

caridy Apr 23, 2013

caridy commented Apr 23, 2013

passy commented Apr 23, 2013

gvaish commented Apr 23, 2013

sindresorhus commented May 9, 2013

gvaish commented May 10, 2013

gvaish commented May 13, 2013

gvaish commented May 13, 2013

sindresorhus commented May 13, 2013

stephenplusplus commented May 13, 2013

stephenplusplus commented May 14, 2013

gvaish commented May 14, 2013

passy commented May 14, 2013

gvaish commented May 23, 2013

passy commented May 23, 2013

addyosmani commented Jul 13, 2013

gvaish commented Jul 16, 2013

passy commented Jul 16, 2013

sindresorhus commented Aug 17, 2013

sindresorhus commented Aug 27, 2013

TodoMVC using Mojito (v0.5.6 - with updates) #507

TodoMVC using Mojito (v0.5.6 - with updates) #507

Conversation

gvaish commented Mar 28, 2013

Commit log

passy commented Mar 28, 2013

gvaish commented Mar 28, 2013

gvaish commented Mar 28, 2013

passy commented Apr 4, 2013

gvaish commented Apr 5, 2013

addyosmani commented Apr 10, 2013

gvaish commented Apr 12, 2013

gvaish commented Apr 13, 2013

gvaish commented Apr 16, 2013

passy commented Apr 16, 2013

addyosmani commented Apr 23, 2013

caridy Apr 23, 2013

Choose a reason for hiding this comment

gvaish Apr 23, 2013

Choose a reason for hiding this comment

caridy Apr 23, 2013

Choose a reason for hiding this comment

caridy commented Apr 23, 2013

passy commented Apr 23, 2013

gvaish commented Apr 23, 2013

sindresorhus commented May 9, 2013

gvaish commented May 10, 2013

gvaish commented May 13, 2013

gvaish commented May 13, 2013

sindresorhus commented May 13, 2013

stephenplusplus commented May 13, 2013

stephenplusplus commented May 14, 2013

gvaish commented May 14, 2013

passy commented May 14, 2013

gvaish commented May 23, 2013

passy commented May 23, 2013

addyosmani commented Jul 13, 2013

gvaish commented Jul 16, 2013

passy commented Jul 16, 2013

sindresorhus commented Aug 17, 2013

sindresorhus commented Aug 27, 2013