Improvements over file encoding feature #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
commented
Sep 13, 2021
| :param coerce_list_concurrently: whether or not list will be coerced | ||
| concurrently | ||
| :param coerce_parent_concurrently: whether or not field will be coerced | ||
| concurrently | ||
| tartiflette `default_arguments_coercer |
There was a problem hiding this comment.
This line was mistakenly moved here in previous commits by prepending descriptions for other arguments, and belongs to custom_default_arguments_coercer argument.
abusi
approved these changes
Sep 13, 2021
mkniewallner
force-pushed
the
improvements-file-encoding
branch
from
313b492 to
130a3a3
Compare
mkniewallner
force-pushed
the
improvements-file-encoding
branch
from
130a3a3 to
ee2c924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your pull-request, make sure the following is done.
masterso that it can be merged easily.Learn more about contributing
Description
Follow up on #522
sdl_file_encodingtocreate_engine, so that it is iso withEngine