fix: handle out of sync errors when returning mempool transactions #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
SWvheerden
reviewed
Aug 31, 2023
| &self, | ||
| excess_sigs: &[PrivateKey], | ||
| ) -> Result<(Vec<Arc<Transaction>>, Vec<PrivateKey>), MempoolError> { | ||
| let (found_txns, remaining) = match self.unconfirmed_pool.retrieve_by_excess_sigs(excess_sigs) { |
There was a problem hiding this comment.
Suggested change
| let (found_txns, remaining) = match self.unconfirmed_pool.retrieve_by_excess_sigs(excess_sigs) { | |
| let (found_txns, remaining) = self.unconfirmed_pool.retrieve_by_excess_sigs(excess_sigs)?; |
why not do this?
There was a problem hiding this comment.
Because I overlooked the possibility 🙃
updated.
SWvheerden
approved these changes
Aug 31, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new error type and gracefully recover from possible runtime panic.
Motivation and Context
Currently, there is a minimal possibility that the collection of tx's is out sync. If this occurs the base node will likely crash.
How Has This Been Tested?
CI
Breaking Changes