feat: new message callback to chat-ffi #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
chat-ffi-new-message-callback
branch
from
26d31ea to
55475fc
Compare
Test Results (Integration tests) 2 files + 2 11 suites +11 20m 15s ⏱️ + 20m 15s For more details on these failures, see this check. Results for commit 55475fc. ± Comparison against base commit f68b85f. ♻️ This comment has been updated with latest results. |
brianp
changed the title
SWvheerden
approved these changes
Jul 14, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a callback function to the chat ffi when a new message is received
Motivation and Context
So ffi consumers don't need to poll for new messages.
How Has This Been Tested?
Cucumber
What process can a PR reviewer use to test or verify this change?
Review the general implementation style.
Breaking Changes