fix(clients): fix tari nodejs client proto paths #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
CR-insufficient_context
|
You also need to fix the path in github actions |
stringhandler
previously approved these changes
Sep 27, 2022
stringhandler
removed
CR-insufficient_context
sdbondi
force-pushed
the
fix-ci-proto-path
branch
3 times, most recently
from
5f8e8dc to
aa7cf76
Compare
sdbondi
force-pushed
the
fix-ci-proto-path
branch
from
aa7cf76 to
1b3a1f6
Compare
sdbondi
force-pushed
the
fix-ci-proto-path
branch
from
c1dd6de to
1a39f70
Compare
sdbondi
force-pushed
the
fix-ci-proto-path
branch
from
1a39f70 to
6c6c41d
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 29, 2022
…re-dan * network-dependent-grpc-ports: feat: different default grpc ports for different networks fix(clients): fix tari nodejs client proto paths (tari-project#4743) chore: disallow onion v2 (tari-project#4745) feat: change priority in mempool to take into account age (tari-project#4737) feat: trigger mempool sync on lag (tari-project#4730) fix(core): use compact inputs for block propagation (tari-project#4714) ci: deny dbg macro (tari-project#4740)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 3, 2022
* development: v0.38.5 feat: different default grpc ports for different networks (tari-project#4755) fix(core): broken doctests (tari-project#4763) ci: fix coverage job ci: run coverage on prs (tari-project#4738) fix(comms): fixes edge case where online status event does not get published (tari-project#4756) fix(dht/encryption): greatly reduce heap allocations for encrypted messaging (tari-project#4753) docs: explain the emission curve parameters (tari-project#4750) fix(comms/peer_manager): add migration to remove onionv2 addresses (tari-project#4748) fix(ci): add cargo cache, reduce Ubuntu dependencies and action on pull_request (tari-project#4757) feat(tariscript): adds ToRistrettoPoint op-code (tari-project#4749) fix: cli wallet cucumber (tari-project#4739) fix(clients): fix tari nodejs client proto paths (tari-project#4743) chore: disallow onion v2 (tari-project#4745) feat: change priority in mempool to take into account age (tari-project#4737) feat: trigger mempool sync on lag (tari-project#4730) fix(core): use compact inputs for block propagation (tari-project#4714) ci: deny dbg macro (tari-project#4740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses correct path for proto files for nodejs wallet client
Motivation and Context
NodeJS clients were put in
nodejsdirectory, however the relative path to the proto files were not updatedHow Has This Been Tested?
Running integration tests