-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: compact block propagation #3704
Merged
aviator-app
merged 5 commits into
tari-project:development
from
sdbondi:core-compact-block-request
Jan 14, 2022
Merged
feat!: compact block propagation #3704
aviator-app
merged 5 commits into
tari-project:development
from
sdbondi:core-compact-block-request
Jan 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9fbbd1
to
6956f09
Compare
6956f09
to
e6bb606
Compare
delta1
reviewed
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👏
Some very minor comments while I build and test
base_layer/core/src/base_node/comms_interface/outbound_interface.rs
Outdated
Show resolved
Hide resolved
delta1
reviewed
Jan 14, 2022
base_layer/core/src/base_node/comms_interface/outbound_interface.rs
Outdated
Show resolved
Hide resolved
delta1
reviewed
Jan 14, 2022
base_layer/core/src/base_node/comms_interface/outbound_interface.rs
Outdated
Show resolved
Hide resolved
3fd4967
to
931bd37
Compare
743d15d
to
5f5fd45
Compare
stringhandler
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So keen to try this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<block_header, coinbase, excess_sigs>
Motivation and Context
In the majority of cases, the inputs, outputs and kernels to be inserted in a block are already known and exist in the mempool. Previously, a propagated new block message would just contain the block hash, requiring the node request the full block from the peer. This implementation provides the minimum block data required to assemble a valid block and propagates that message (typically less than 100kb).
How Has This Been Tested?
Updated tests, existing block propagation tests
Manually: 3 base nodes, 1 wallet and 4 blocks worth of transactions in the mempool on dibbler