refactor: reintroduce generic substream in client rpc #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic substream was removed in order to more closely test RPC/yamux interaction but that was incorrect. The tests should have just been updated without removing the generic. This PR reintroduces them so that an RPC client mock can more easily be created.
stringhandler
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic substream was removed in order to more closely test RPC/yamux
interaction but that was incorrect. The tests should have just been
updated without removing the generic + add new StreamId abstraction.
This PR reintroduces them so that an RPC client mock can more easily be created.
Motivation and Context
How Has This Been Tested?
Existing tests pass