Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] Bundle sqlite dependency #3036

Merged
merged 2 commits into from
Jul 7, 2021
Merged

[common] Bundle sqlite dependency #3036

merged 2 commits into from
Jul 7, 2021

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Jun 25, 2021 •
edited
Loading

Description

Bundles the sqlite dependency in the codebase

Motivation and Context

One less dylib

How Has This Been Tested?

On a new ubuntu 20.04 VM

  • install the prereqs without libsqlite3-dev
  • attempt to compile
  • failed
  • added this commit
  • compiled successfully
  • launched base node and start syncing

todo: Still to be tested on Windows

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

SWvheerden
SWvheerden previously approved these changes Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stringhandler
stringhandler previously approved these changes Jul 7, 2021
View reviewed changes
@stringhandler stringhandler dismissed stale reviews from SWvheerden and themself via 35ca97b July 7, 2021 08:58
@stringhandler stringhandler merged commit 7bd1341 into tari-project:development Jul 7, 2021
@delta1 delta1 deleted the sqlite branch July 7, 2021 09:14
@stringhandler stringhandler mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden left review comments

@stringhandler stringhandler stringhandler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delta1 @SWvheerden @stringhandler