Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet can request messages that are over the size limit for rpc messages #5299

Closed
SWvheerden opened this issue Apr 11, 2023 · 0 comments · Fixed by #5302
Closed

Wallet can request messages that are over the size limit for rpc messages #5299

SWvheerden opened this issue Apr 11, 2023 · 0 comments · Fixed by #5302
Assignees
@SWvheerden
Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.

Comments

@SWvheerden
Copy link
Collaborator

See PR #5298

2023-04-06 17:08:52.630699700 [wallet::utxo_scanning] WARN  Failed to scan UTXO's from base node 6b8a34873128fc5323a86fbe6e: RpcStatus: `MalformedResponse: The response size exceeded the maximum allowed payload size. Max = 4.0000 MiB, Got = 4.5924 MiB`
2023-04-06 17:08:52.631420600 [wallet::utxo_scanning] WARN  Failed to scan UTXO's from base node 6b8a34873128fc5323a86fbe6e: RpcError: `Remote peer unexpectedly closed the RPC connection`
2023-04-06 17:08:52.631441300 [wallet::utxo_scanning] ERROR Error scanning UTXOs: Utxo Scanning Error: 'Failed to scan UTXO's after 2 attempt(s) using sync peer(s). Aborting...

These requests should be paged
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet labels Apr 11, 2023
@hansieodendaal hansieodendaal mentioned this issue Apr 11, 2023
Closed
4 tasks
@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Apr 11, 2023
@SWvheerden SWvheerden moved this from Must Do to In Progress in Tari Esme Testnet Apr 11, 2023
@SWvheerden SWvheerden self-assigned this Apr 11, 2023
@SWvheerden SWvheerden mentioned this issue Apr 11, 2023
Merged
4 tasks
@SWvheerden SWvheerden moved this from In Progress to In Review in Tari Esme Testnet Apr 12, 2023
stringhandler pushed a commit that referenced this issue Apr 12, 2023
@SWvheerden
feat!: add paging to utxo stream request (#5302)
3540309 
Description
---
Adds paging to the utxo stream to handle the large amount of faucet
utxos

Motivation and Context
---
See: #5299

How Has This Been Tested?
---
unit tests

Fixes: #5299

What process can a PR reviewer use to test or verify this change?
---
See PR #5298 


Breaking Changes
---
Changes request service

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
A-base_node Area - The Tari base node executable and libraries A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: add paging to utxo stream request SWvheerden/tari
1 participant
@SWvheerden