Transaction builder over validates #4813
Assignees
Labels
A-wallet
Area - related to the wallet
C-performance
adds no new functionality but improves performance. Benchmarks will be included.
P-controversial
Process - This PR or Issue is controversial and/or requires more attention that simpler issues
Milestone
Comments
SWvheerden
added
the
C-performance
|
It seems worthwhile to investigate this, but I would be really cautious in analysing the validation dependency chain. |
|
The only place where a transaction really needs to be validated for chain security is on the base nodes when accepting a transaction to be put into the mempool, and when accepting a new block. The rest are all just sanity checks. |
|
And from the wallet's perspective? |
|
Its all just sanity checks, and not even complete checks as the wallet cannot check consensus rules such as duplicate outputs etc. |
stringhandler
added
A-wallet
SWvheerden
moved this from Selected for development
to In Progress
in Tari Esme Testnet
SWvheerden
moved this from In Progress
to Selected for development
in Tari Esme Testnet
SWvheerden
moved this from Selected for development
to In Progress
in Tari Esme Testnet
stringhandler
pushed a commit
that referenced
this issue
Dec 1, 2022
Description --- This removes extra validation from transaction protocols. Motivation and Context --- The transaction protocols do a lot of extra unnecessary validation. For example: The code will run add_output(output), which will validate the range_proof and signatures. The next line will run tx.build(), which will again validate the range_proof and signatures. While these tests are not expensive, they are not free either. The second problem is that when we do aggregate transactions such as with branch: `feature-m-of-n` these validations fail as the signatures are partial until right before we build the final transaction How Has This Been Tested? --- Passes all unit tests Fixes: #4813
Repository owner
moved this from In Review
to Done
in Tari Esme Testnet
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The transaction builder seems to validate every single time we add an output, add a signature etc.
It also validates at the end when it builds.
We can either remove the final validation check, or the individual checks as it does not seem performant to validate everything every single time.
The text was updated successfully, but these errors were encountered: