Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console wallet] Make encumber queries run in sql #4621

Closed
hansieodendaal opened this issue Sep 6, 2022 · 1 comment
Closed

[console wallet] Make encumber queries run in sql #4621

hansieodendaal opened this issue Sep 6, 2022 · 1 comment
Assignees
@hansieodendaal

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Sep 6, 2022 •
edited
Loading

Extremely slow sql db operations with encumber queries when trying to spend ~60,500 dust UTXOs in 20x one-sided and 20x stealth transactions in script mode from one sender wallet to one receiver wallet.

With fn short_term_encumber_outputs and fn confirm_encumbered_outputs:

  • Combine the read and write operations into one sql query and remove the for loops
@hansieodendaal hansieodendaal self-assigned this Sep 6, 2022
@hansieodendaal hansieodendaal moved this from In Progress to In Review in Tari Esme Testnet Sep 12, 2022
@hansieodendaal hansieodendaal moved this from In Review to In Progress in Tari Esme Testnet Sep 12, 2022
@hansieodendaal hansieodendaal mentioned this issue Sep 12, 2022
Merged
stringhandler pushed a commit that referenced this issue Sep 20, 2022
@hansieodendaal
feat: wallet optimize output manager db operations (#4663)
25c4d99 
Description
---
Optimized output manager and contacts liveness database operations to do as much work as possible inside the SQL database instead of inside Rust code. These changes are most noticeable where a query would return a number of outputs and followed by updating each output one by one.


Motivation and Context
---
See #4621

How Has This Been Tested?
---
- Passed unit tests
- Passed cucumber tests
- System-level tests
@hansieodendaal hansieodendaal moved this from In Progress to In Review in Tari Esme Testnet Sep 20, 2022
@hansieodendaal
Copy link
Contributor Author

Close by #4663

Repository owner moved this from In Review to Done in Tari Esme Testnet Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hansieodendaal