Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPC[base node]: ListHeaders and GetHeadersByHeight do the same thing #4372

Closed
stringhandler opened this issue Aug 1, 2022 · 0 comments · Fixed by #4515
Closed

GRPC[base node]: ListHeaders and GetHeadersByHeight do the same thing #4372

stringhandler opened this issue Aug 1, 2022 · 0 comments · Fixed by #4515
Assignees
@SWvheerden
Labels
E-good_first_issue Experience Level - Good for newcomers

Comments

@stringhandler
Copy link
Collaborator

In the BaseNode GRPC, there are two methods:

  1. ListHeaders
  2. GetHeaderByHeight

These two methods do the same thing, or at least, you can call ListHeaders with a single height to get one header, but GetHeadersByHeight returns extra information, such as confirmations and rewards.

I suggest removing the single call and adding the extra fields to the ListHeader call
@stringhandler stringhandler changed the title [CleanUp] GRPC[base node]: ListHeaders and GetHeadersByHeight do the same thing Aug 1, 2022
@CjS77 CjS77 added the E-good_first_issue Experience Level - Good for newcomers label Aug 1, 2022
@SWvheerden SWvheerden moved this to Backlog in Tari Esme Testnet Aug 15, 2022
@SWvheerden SWvheerden moved this from Backlog to In Progress in Tari Esme Testnet Aug 19, 2022
@SWvheerden SWvheerden self-assigned this Aug 19, 2022
@SWvheerden SWvheerden mentioned this issue Aug 22, 2022
Merged
@SWvheerden SWvheerden moved this from In Progress to In Review in Tari Esme Testnet Aug 22, 2022
stringhandler pushed a commit that referenced this issue Aug 25, 2022
@SWvheerden
feat: merge grpc list headers commands (#4515)
18a88d7 
Description
---
The GRPC server has 2 methods, `getHeaderByHeight` and `getHeaderByHeight`. 
These 2 methods are especially duplicated, this removes `getHeaderByHeight` method and adds the additional fields that this method had to `getHeaderByHeight`

Fixes: #4372
Repository owner moved this from In Review to Done in Tari Esme Testnet Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
E-good_first_issue Experience Level - Good for newcomers
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: merge grpc list headers commands SWvheerden/tari
3 participants
@SWvheerden @stringhandler @CjS77