Skip to content

Commit

Permalink
[ABI-stability] Revert API change for HeapProfiler::TakeHeapSnapshot
Browse files Browse the repository at this point in the history
This reverts a small part of 7f52e4f.
  • Loading branch information
targos committed Apr 17, 2021
1 parent 69aa92d commit a39efa8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions include/v8-profiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -900,8 +900,7 @@ class V8_EXPORT HeapProfiler {
const HeapSnapshot* TakeHeapSnapshot(
ActivityControl* control = nullptr,
ObjectNameResolver* global_object_name_resolver = nullptr,
bool treat_global_objects_as_roots = true,
bool capture_numeric_value = false);
bool treat_global_objects_as_roots = true);

/**
* Starts tracking of heap objects population statistics. After calling
Expand Down
5 changes: 2 additions & 3 deletions src/api/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10043,11 +10043,10 @@ void HeapProfiler::ClearObjectIds() {

const HeapSnapshot* HeapProfiler::TakeHeapSnapshot(
ActivityControl* control, ObjectNameResolver* resolver,
bool treat_global_objects_as_roots, bool capture_numeric_value) {
bool treat_global_objects_as_roots) {
return reinterpret_cast<const HeapSnapshot*>(
reinterpret_cast<i::HeapProfiler*>(this)->TakeSnapshot(
control, resolver, treat_global_objects_as_roots,
capture_numeric_value));
control, resolver, treat_global_objects_as_roots, false));
}

void HeapProfiler::StartTrackingHeapObjects(bool track_allocations) {
Expand Down

0 comments on commit a39efa8

Please sign in to comment.