This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
fix: Subchannel Posting Should Not Error Entire Process #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#99 was supposed to fix the issues with error handling, but it turns out the errors were not bubbling as expected and we were still getting unhandled promise rejections. It was clear that we didn't need to bomb the process if the message sending failed, since we run a post to comment routine after posting. So this PR removes unnecessary error throwing and provides clearer messaging.
Motivation and Context
^
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: